Messages in this thread | | | Date | Thu, 5 Dec 2019 13:13:10 +0100 | From | Greg KH <> | Subject | Re: [PATCH] tty: omap-serial: remove set but unused variable |
| |
On Thu, Dec 05, 2019 at 08:04:36PM +0800, Xiongfeng Wang wrote: > Fix the following warning: > drivers/tty/serial/omap-serial.c: In function serial_omap_rlsi: > drivers/tty/serial/omap-serial.c:496:16: warning: variable ch set but not used [-Wunused-but-set-variable] > > Reported-by: Hulk Robot <hulkci@huawei.com> > Signed-off-by: Xiongfeng Wang <wangxiongfeng2@huawei.com> > --- > drivers/tty/serial/omap-serial.c | 3 +-- > 1 file changed, 1 insertion(+), 2 deletions(-) > > diff --git a/drivers/tty/serial/omap-serial.c b/drivers/tty/serial/omap-serial.c > index 6420ae5..54ee3ae 100644 > --- a/drivers/tty/serial/omap-serial.c > +++ b/drivers/tty/serial/omap-serial.c > @@ -493,10 +493,9 @@ static unsigned int check_modem_status(struct uart_omap_port *up) > static void serial_omap_rlsi(struct uart_omap_port *up, unsigned int lsr) > { > unsigned int flag; > - unsigned char ch = 0; > > if (likely(lsr & UART_LSR_DR)) > - ch = serial_in(up, UART_RX); > + serial_in(up, UART_RX);
Shouldn't you be doing something with 'ch'?
| |