Messages in this thread | | | Date | Thu, 5 Dec 2019 10:44:00 +0100 | From | Michal Hocko <> | Subject | Re: [PATCH] mm: vmscan: protect shrinker idr replace with CONFIG_MEMCG |
| |
On Thu 05-12-19 03:16:18, Yang Shi wrote: > Since commit 0a432dcbeb32edcd211a5d8f7847d0da7642a8b4 ("mm: shrinker: > make shrinker not depend on memcg kmem"), shrinkers' idr is protected by > CONFIG_MEMCG instead of CONFIG_MEMCG_KMEM, so it makes no sense to > protect shrinker idr replace with CONFIG_MEMCG_KMEM. > > Cc: Kirill Tkhai <ktkhai@virtuozzo.com> > Cc: Johannes Weiner <hannes@cmpxchg.org> > Cc: Michal Hocko <mhocko@suse.com> > Cc: Shakeel Butt <shakeelb@google.com> > Cc: Roman Gushchin <guro@fb.com> > Signed-off-by: Yang Shi <yang.shi@linux.alibaba.com>
Acked-by: Michal Hocko <mhocko@suse.com>
> --- > mm/vmscan.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/mm/vmscan.c b/mm/vmscan.c > index ee4eecc..e7f10c4 100644 > --- a/mm/vmscan.c > +++ b/mm/vmscan.c > @@ -422,7 +422,7 @@ void register_shrinker_prepared(struct shrinker *shrinker) > { > down_write(&shrinker_rwsem); > list_add_tail(&shrinker->list, &shrinker_list); > -#ifdef CONFIG_MEMCG_KMEM > +#ifdef CONFIG_MEMCG > if (shrinker->flags & SHRINKER_MEMCG_AWARE) > idr_replace(&shrinker_idr, shrinker, shrinker->id); > #endif > -- > 1.8.3.1
-- Michal Hocko SUSE Labs
| |