Messages in this thread Patch in this message | | | Date | Wed, 4 Dec 2019 11:47:33 +0100 | From | Peter Zijlstra <> | Subject | Re: [PATCH v6 10/18] sh/tlb: Convert SH to generic mmu_gather |
| |
On Tue, Dec 03, 2019 at 12:19:00PM +0100, Geert Uytterhoeven wrote: > Hoi Peter, > > On Tue, Feb 19, 2019 at 11:35 AM Peter Zijlstra <peterz@infradead.org> wrote: > > Generic mmu_gather provides everything SH needs (range tracking and > > cache coherency). > > > > Cc: Will Deacon <will.deacon@arm.com> > > Cc: "Aneesh Kumar K.V" <aneesh.kumar@linux.vnet.ibm.com> > > Cc: Andrew Morton <akpm@linux-foundation.org> > > Cc: Nick Piggin <npiggin@gmail.com> > > Cc: Yoshinori Sato <ysato@users.sourceforge.jp> > > Cc: Rich Felker <dalias@libc.org> > > Signed-off-by: Peter Zijlstra (Intel) <peterz@infradead.org> > > I got remote access to an SH7722-based Migo-R again, which spews a long > sequence of BUGs during userspace startup. I've bisected this to commit > c5b27a889da92f4a ("sh/tlb: Convert SH to generic mmu_gather").
Whoopsy.. also, is this really the first time anybody booted an SH kernel in over a year ?!?
> Do you have a clue?
Does the below help?
diff --git a/arch/sh/include/asm/pgalloc.h b/arch/sh/include/asm/pgalloc.h index 22d968bfe9bb..73a2c00de6c5 100644 --- a/arch/sh/include/asm/pgalloc.h +++ b/arch/sh/include/asm/pgalloc.h @@ -36,9 +36,8 @@ do { \ #if CONFIG_PGTABLE_LEVELS > 2 #define __pmd_free_tlb(tlb, pmdp, addr) \ do { \ - struct page *page = virt_to_page(pmdp); \ - pgtable_pmd_page_dtor(page); \ - tlb_remove_page((tlb), page); \ + pgtable_pmd_page_dtor(pmdp); \ + tlb_remove_page((tlb), (pmdp)); \ } while (0); #endif
| |