lkml.org 
[lkml]   [2019]   [Dec]   [4]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
From
Date
SubjectRe: [PATCH 5/6] thermal: brcmstb_thermal: Restructure interrupt registration
On Wed, Oct 30, 2019 at 11:52 PM Florian Fainelli <f.fainelli@gmail.com> wrote:
>
> If we are successful grabbing the interrupt resource, then register an
> interrupt handler, this makes it easier to support the interrupt as
> being optional, which is it for 7216.
>
> Signed-off-by: Florian Fainelli <f.fainelli@gmail.com>

Reviewed-by: Amit Kucheria <amit.kucheria@linaro.org>

> ---
> drivers/thermal/broadcom/brcmstb_thermal.c | 19 +++++++++----------
> 1 file changed, 9 insertions(+), 10 deletions(-)
>
> diff --git a/drivers/thermal/broadcom/brcmstb_thermal.c b/drivers/thermal/broadcom/brcmstb_thermal.c
> index 41d4a142707c..64f715053ce9 100644
> --- a/drivers/thermal/broadcom/brcmstb_thermal.c
> +++ b/drivers/thermal/broadcom/brcmstb_thermal.c
> @@ -339,16 +339,15 @@ static int brcmstb_thermal_probe(struct platform_device *pdev)
> priv->thermal = thermal;
>
> irq = platform_get_irq(pdev, 0);
> - if (irq < 0) {
> - dev_err(&pdev->dev, "could not get IRQ\n");
> - return irq;
> - }
> - ret = devm_request_threaded_irq(&pdev->dev, irq, NULL,
> - brcmstb_tmon_irq_thread, IRQF_ONESHOT,
> - DRV_NAME, priv);
> - if (ret < 0) {
> - dev_err(&pdev->dev, "could not request IRQ: %d\n", ret);
> - return ret;
> + if (irq >= 0) {
> + ret = devm_request_threaded_irq(&pdev->dev, irq, NULL,
> + brcmstb_tmon_irq_thread,
> + IRQF_ONESHOT,
> + DRV_NAME, priv);
> + if (ret < 0) {
> + dev_err(&pdev->dev, "could not request IRQ: %d\n", ret);
> + return ret;
> + }
> }
>
> dev_info(&pdev->dev, "registered AVS TMON of-sensor driver\n");
> --
> 2.17.1
>

\
 
 \ /
  Last update: 2019-12-04 10:39    [W:0.196 / U:0.140 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site