lkml.org 
[lkml]   [2019]   [Dec]   [4]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
SubjectRe: [PATCH 2/2] fix the SPDX syntax and bash interprester pointer
From
Date
On 12/3/19 1:53 AM, Bhaskar Chowdhury wrote:
> SPDX syntax was complining by checkpatch fixed it,added space before it.
> And add bash interpreter to find by the env .
>
> Signed-off-by: Bhaskar Chowdhury <unixbhaskar@gmail.com>
> ---
> scripts/kernel_modules_info.sh | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/scripts/kernel_modules_info.sh b/scripts/kernel_modules_info.sh
> index f005c47a3aa6..3a9b00988ed3 100755
> --- a/scripts/kernel_modules_info.sh
> +++ b/scripts/kernel_modules_info.sh
> @@ -1,5 +1,5 @@
> -#!/bin/bash -
> -#SPDX-License-Identifier: GPL-2.0
> +#!/usr/bin/env bash
> +# SPDX-License-Identifier: GPL-2.0
> #===============================================================================
> #
> # FILE: kernel_modules_info.sh
>

a. There is no good reason for patch 2/2. Just merge the 2 patches.

b. The big header comment in patch 1/2 is not needed and is unwanted.
Just put some or all of that in the patch description/comment message.


--
~Randy

\
 
 \ /
  Last update: 2019-12-05 04:36    [W:0.035 / U:0.100 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site