lkml.org 
[lkml]   [2019]   [Dec]   [4]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    /
    From
    Date
    SubjectRe: [PATCH v2 06/11] gpiolib: use gpiochip_get_desc() in gpio_ioctl()
    On Wed, Dec 4, 2019 at 6:04 PM Bartosz Golaszewski <brgl@bgdev.pl> wrote:
    >
    > From: Bartosz Golaszewski <bgolaszewski@baylibre.com>
    >
    > Unduplicate the offset check by simply calling gpiochip_get_desc() and
    > checking its return value.
    >

    Reviewed-by: Andy Shevchenko <andy.shevchenko@gmail.com>


    > Signed-off-by: Bartosz Golaszewski <bgolaszewski@baylibre.com>
    > ---
    > drivers/gpio/gpiolib.c | 7 ++++---
    > 1 file changed, 4 insertions(+), 3 deletions(-)
    >
    > diff --git a/drivers/gpio/gpiolib.c b/drivers/gpio/gpiolib.c
    > index 17796437d7be..b7043946c029 100644
    > --- a/drivers/gpio/gpiolib.c
    > +++ b/drivers/gpio/gpiolib.c
    > @@ -1175,10 +1175,11 @@ static long gpio_ioctl(struct file *filp, unsigned int cmd, unsigned long arg)
    >
    > if (copy_from_user(&lineinfo, ip, sizeof(lineinfo)))
    > return -EFAULT;
    > - if (lineinfo.line_offset >= gdev->ngpio)
    > - return -EINVAL;
    >
    > - desc = &gdev->descs[lineinfo.line_offset];
    > + desc = gpiochip_get_desc(chip, lineinfo.line_offset);
    > + if (IS_ERR(desc))
    > + return PTR_ERR(desc);
    > +
    > if (desc->name) {
    > strncpy(lineinfo.name, desc->name,
    > sizeof(lineinfo.name));
    > --
    > 2.23.0
    >


    --
    With Best Regards,
    Andy Shevchenko

    \
     
     \ /
      Last update: 2019-12-04 23:22    [W:3.553 / U:0.008 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site