lkml.org 
[lkml]   [2019]   [Dec]   [4]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    Patch in this message
    /
    From
    Subject[PATCH 4.14 117/209] tipc: fix a missing check of genlmsg_put
    Date
    From: Kangjie Lu <kjlu@umn.edu>

    [ Upstream commit 46273cf7e009231d2b6bc10a926e82b8928a9fb2 ]

    genlmsg_put could fail. The fix inserts a check of its return value, and
    if it fails, returns -EMSGSIZE.

    Signed-off-by: Kangjie Lu <kjlu@umn.edu>
    Signed-off-by: David S. Miller <davem@davemloft.net>
    Signed-off-by: Sasha Levin <sashal@kernel.org>
    ---
    net/tipc/netlink_compat.c | 2 ++
    1 file changed, 2 insertions(+)

    diff --git a/net/tipc/netlink_compat.c b/net/tipc/netlink_compat.c
    index 1c8ac0c11008c..91d51a595ac23 100644
    --- a/net/tipc/netlink_compat.c
    +++ b/net/tipc/netlink_compat.c
    @@ -974,6 +974,8 @@ static int tipc_nl_compat_publ_dump(struct tipc_nl_compat_msg *msg, u32 sock)

    hdr = genlmsg_put(args, 0, 0, &tipc_genl_family, NLM_F_MULTI,
    TIPC_NL_PUBL_GET);
    + if (!hdr)
    + return -EMSGSIZE;

    nest = nla_nest_start(args, TIPC_NLA_SOCK);
    if (!nest) {
    --
    2.20.1


    \
     
     \ /
      Last update: 2019-12-04 19:22    [W:5.385 / U:0.004 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site