Messages in this thread | | | Date | Mon, 30 Dec 2019 21:36:16 +0100 | From | Andrew Lunn <> | Subject | Re: [PATCH RFC net-next 05/19] net: dsa: tag_ar9331: add GRO callbacks |
| |
On Mon, Dec 30, 2019 at 10:20:50AM -0800, Florian Fainelli wrote: > On 12/30/19 6:30 AM, Alexander Lobakin wrote: > > Add GRO callbacks to the AR9331 tagger so GRO layer can now process > > such frames. > > > > Signed-off-by: Alexander Lobakin <alobakin@dlink.ru> > > This is a good example and we should probably build a tagger abstraction > that is much simpler to fill in callbacks for (although indirect > function calls may end-up killing performance with retpoline and > friends), but let's consider this idea.
Hi Florian
We really do need some numbers here. Does GRO really help? On an ARM or MIPS platform, i don't think retpoline is an issue? But x86 is, and we do have a few x86 boards with switches.
Maybe we can do some macro magic instead of function pointers, if we can keep it all within one object file?
Andrew
| |