lkml.org 
[lkml]   [2019]   [Dec]   [30]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    /
    Date
    From
    SubjectRe: [PATCH RFC net-next 05/19] net: dsa: tag_ar9331: add GRO callbacks
    On Mon, Dec 30, 2019 at 10:20:50AM -0800, Florian Fainelli wrote:
    > On 12/30/19 6:30 AM, Alexander Lobakin wrote:
    > > Add GRO callbacks to the AR9331 tagger so GRO layer can now process
    > > such frames.
    > >
    > > Signed-off-by: Alexander Lobakin <alobakin@dlink.ru>
    >
    > This is a good example and we should probably build a tagger abstraction
    > that is much simpler to fill in callbacks for (although indirect
    > function calls may end-up killing performance with retpoline and
    > friends), but let's consider this idea.

    Hi Florian

    We really do need some numbers here. Does GRO really help? On an ARM
    or MIPS platform, i don't think retpoline is an issue? But x86 is, and
    we do have a few x86 boards with switches.

    Maybe we can do some macro magic instead of function pointers, if we
    can keep it all within one object file?

    Andrew

    \
     
     \ /
      Last update: 2019-12-30 21:37    [W:4.090 / U:0.172 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site