Messages in this thread | | | From | Vitaly Kuznetsov <> | Subject | Re: [PATCH v3 1/5] KVM: X86: Fix kvm_bitmap_or_dest_vcpus() to use irq shorthand | Date | Tue, 03 Dec 2019 10:25:13 +0100 |
| |
Peter Xu <peterx@redhat.com> writes:
> The 3rd parameter of kvm_apic_match_dest() is the irq shorthand, > rather than the irq delivery mode. > > Fixes: 7ee30bc132c683d06a6d9e360e39e483e3990708
Better expressed as
Fixes: 7ee30bc132c6 ("KVM: x86: deliver KVM IOAPIC scan request to target vCPUs")
> Signed-off-by: Peter Xu <peterx@redhat.com> > --- > arch/x86/kvm/lapic.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/arch/x86/kvm/lapic.c b/arch/x86/kvm/lapic.c > index cf9177b4a07f..1eabe58bb6d5 100644 > --- a/arch/x86/kvm/lapic.c > +++ b/arch/x86/kvm/lapic.c > @@ -1151,7 +1151,7 @@ void kvm_bitmap_or_dest_vcpus(struct kvm *kvm, struct kvm_lapic_irq *irq, > if (!kvm_apic_present(vcpu)) > continue; > if (!kvm_apic_match_dest(vcpu, NULL, > - irq->delivery_mode, > + irq->shorthand, > irq->dest_id, > irq->dest_mode)) > continue;
Reviewed-by: Vitaly Kuznetsov <vkuznets@redhat.com>
-- Vitaly
| |