lkml.org 
[lkml]   [2019]   [Dec]   [3]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    Patch in this message
    /
    From
    Subject[PATCH 4.19 115/321] mtd: rawnand: sunxi: Write pageprog related opcodes to WCMD_SET
    Date
    From: Boris Brezillon <boris.brezillon@bootlin.com>

    [ Upstream commit 732774437ae01d9882e60314e303898e63c7f038 ]

    The opcodes used by the controller when doing batched page prog should
    be written in NFC_REG_WCMD_SET not FC_REG_RCMD_SET. Luckily, the
    default NFC_REG_WCMD_SET value matches the one we set in the driver
    which explains why we didn't notice the problem.

    Fixes: 614049a8d904 ("mtd: nand: sunxi: add support for DMA assisted operations")
    Signed-off-by: Boris Brezillon <boris.brezillon@bootlin.com>
    Signed-off-by: Miquel Raynal <miquel.raynal@bootlin.com>
    Signed-off-by: Sasha Levin <sashal@kernel.org>
    ---
    drivers/mtd/nand/raw/sunxi_nand.c | 2 +-
    1 file changed, 1 insertion(+), 1 deletion(-)

    diff --git a/drivers/mtd/nand/raw/sunxi_nand.c b/drivers/mtd/nand/raw/sunxi_nand.c
    index 1f0b7ee38df56..5b5f4d25a3e12 100644
    --- a/drivers/mtd/nand/raw/sunxi_nand.c
    +++ b/drivers/mtd/nand/raw/sunxi_nand.c
    @@ -1397,7 +1397,7 @@ static int sunxi_nfc_hw_ecc_write_page_dma(struct mtd_info *mtd,
    sunxi_nfc_randomizer_enable(mtd);

    writel((NAND_CMD_RNDIN << 8) | NAND_CMD_PAGEPROG,
    - nfc->regs + NFC_REG_RCMD_SET);
    + nfc->regs + NFC_REG_WCMD_SET);

    dma_async_issue_pending(nfc->dmac);

    --
    2.20.1


    \
     
     \ /
      Last update: 2019-12-04 00:06    [W:2.172 / U:0.040 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site