lkml.org 
[lkml]   [2019]   [Dec]   [3]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    Patch in this message
    /
    From
    Subject[PATCH 4.19 214/321] tipc: fix memory leak in tipc_nl_compat_publ_dump
    Date
    From: Gustavo A. R. Silva <gustavo@embeddedor.com>

    [ Upstream commit f87d8ad9233f115db92c6c087d58403b0009ed36 ]

    There is a memory leak in case genlmsg_put fails.

    Fix this by freeing *args* before return.

    Addresses-Coverity-ID: 1476406 ("Resource leak")
    Fixes: 46273cf7e009 ("tipc: fix a missing check of genlmsg_put")
    Signed-off-by: Gustavo A. R. Silva <gustavo@embeddedor.com>
    Acked-by: Ying Xue <ying.xue@windriver.com>
    Signed-off-by: David S. Miller <davem@davemloft.net>
    Signed-off-by: Sasha Levin <sashal@kernel.org>
    ---
    net/tipc/netlink_compat.c | 4 +++-
    1 file changed, 3 insertions(+), 1 deletion(-)

    diff --git a/net/tipc/netlink_compat.c b/net/tipc/netlink_compat.c
    index fab0384d2b4b3..b4860084a8f56 100644
    --- a/net/tipc/netlink_compat.c
    +++ b/net/tipc/netlink_compat.c
    @@ -983,8 +983,10 @@ static int tipc_nl_compat_publ_dump(struct tipc_nl_compat_msg *msg, u32 sock)

    hdr = genlmsg_put(args, 0, 0, &tipc_genl_family, NLM_F_MULTI,
    TIPC_NL_PUBL_GET);
    - if (!hdr)
    + if (!hdr) {
    + kfree_skb(args);
    return -EMSGSIZE;
    + }

    nest = nla_nest_start(args, TIPC_NLA_SOCK);
    if (!nest) {
    --
    2.20.1


    \
     
     \ /
      Last update: 2019-12-03 23:56    [W:6.116 / U:0.100 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site