lkml.org 
[lkml]   [2019]   [Dec]   [29]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    Patch in this message
    /
    From
    Subject[PATCH 5.4 036/434] btrfs: do not leak reloc root if we fail to read the fs root
    Date
    From: Josef Bacik <josef@toxicpanda.com>

    commit ca1aa2818a53875cfdd175fb5e9a2984e997cce9 upstream.

    If we fail to read the fs root corresponding with a reloc root we'll
    just break out and free the reloc roots. But we remove our current
    reloc_root from this list higher up, which means we'll leak this
    reloc_root. Fix this by adding ourselves back to the reloc_roots list
    so we are properly cleaned up.

    CC: stable@vger.kernel.org # 4.4+
    Reviewed-by: Filipe Manana <fdmanana@suse.com>
    Reviewed-by: Johannes Thumshirn <jthumshirn@suse.de>
    Signed-off-by: Josef Bacik <josef@toxicpanda.com>
    Reviewed-by: David Sterba <dsterba@suse.com>
    Signed-off-by: David Sterba <dsterba@suse.com>
    Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>

    ---
    fs/btrfs/relocation.c | 1 +
    1 file changed, 1 insertion(+)

    --- a/fs/btrfs/relocation.c
    +++ b/fs/btrfs/relocation.c
    @@ -4555,6 +4555,7 @@ int btrfs_recover_relocation(struct btrf
    fs_root = read_fs_root(fs_info, reloc_root->root_key.offset);
    if (IS_ERR(fs_root)) {
    err = PTR_ERR(fs_root);
    + list_add_tail(&reloc_root->root_list, &reloc_roots);
    goto out_free;
    }


    \
     
     \ /
      Last update: 2019-12-29 19:12    [W:3.395 / U:0.008 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site