lkml.org 
[lkml]   [2019]   [Dec]   [29]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    Patch in this message
    /
    From
    Subject[PATCH 5.4 395/434] KEYS: asymmetric: return ENOMEM if akcipher_request_alloc() fails
    Date
    From: Eric Biggers <ebiggers@google.com>

    commit bea37414453eb08d4ceffeb60a9d490dbc930cea upstream.

    No error code was being set on this error path.

    Cc: stable@vger.kernel.org
    Fixes: ad4b1eb5fb33 ("KEYS: asym_tpm: Implement encryption operation [ver #2]")
    Fixes: c08fed737126 ("KEYS: Implement encrypt, decrypt and sign for software asymmetric key [ver #2]")
    Reviewed-by: James Morris <jamorris@linux.microsoft.com>
    Signed-off-by: Eric Biggers <ebiggers@google.com>
    Reviewed-by: Jarkko Sakkinen <jarkko.sakkinen@linux.intel.com>
    Signed-off-by: Jarkko Sakkinen <jarkko.sakkinen@linux.intel.com>
    Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>

    ---
    crypto/asymmetric_keys/asym_tpm.c | 1 +
    crypto/asymmetric_keys/public_key.c | 1 +
    2 files changed, 2 insertions(+)

    --- a/crypto/asymmetric_keys/asym_tpm.c
    +++ b/crypto/asymmetric_keys/asym_tpm.c
    @@ -486,6 +486,7 @@ static int tpm_key_encrypt(struct tpm_ke
    if (ret < 0)
    goto error_free_tfm;

    + ret = -ENOMEM;
    req = akcipher_request_alloc(tfm, GFP_KERNEL);
    if (!req)
    goto error_free_tfm;
    --- a/crypto/asymmetric_keys/public_key.c
    +++ b/crypto/asymmetric_keys/public_key.c
    @@ -184,6 +184,7 @@ static int software_key_eds_op(struct ke
    if (IS_ERR(tfm))
    return PTR_ERR(tfm);

    + ret = -ENOMEM;
    req = akcipher_request_alloc(tfm, GFP_KERNEL);
    if (!req)
    goto error_free_tfm;

    \
     
     \ /
      Last update: 2019-12-29 18:57    [W:2.237 / U:0.224 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site