lkml.org 
[lkml]   [2019]   [Dec]   [27]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    Patch in this message
    /
    From
    Subject[PATCH AUTOSEL 5.4 044/187] selftests: safesetid: Move link library to LDLIBS
    Date
    From: Masami Hiramatsu <mhiramat@kernel.org>

    [ Upstream commit be12252212fa3dfed6e75112865095c484c0ce87 ]

    Move -lcap to LDLIBS from CFLAGS because it is a library
    to be linked.

    Without this, safesetid failed to build with link error
    as below.

    ----
    /usr/bin/ld: /tmp/ccL8rZHT.o: in function `drop_caps':
    safesetid-test.c:(.text+0xe7): undefined reference to `cap_get_proc'
    /usr/bin/ld: safesetid-test.c:(.text+0x107): undefined reference to `cap_set_flag'
    /usr/bin/ld: safesetid-test.c:(.text+0x10f): undefined reference to `cap_set_proc'
    /usr/bin/ld: safesetid-test.c:(.text+0x117): undefined reference to `cap_free'
    /usr/bin/ld: safesetid-test.c:(.text+0x136): undefined reference to `cap_clear'
    collect2: error: ld returned 1 exit status
    ----

    Fixes: c67e8ec03f3f ("LSM: SafeSetID: add selftest")
    Signed-off-by: Masami Hiramatsu <mhiramat@kernel.org>
    Signed-off-by: Shuah Khan <skhan@linuxfoundation.org>
    Signed-off-by: Sasha Levin <sashal@kernel.org>
    ---
    tools/testing/selftests/safesetid/Makefile | 3 ++-
    1 file changed, 2 insertions(+), 1 deletion(-)

    diff --git a/tools/testing/selftests/safesetid/Makefile b/tools/testing/selftests/safesetid/Makefile
    index 98da7a504737..cac42cd36a1b 100644
    --- a/tools/testing/selftests/safesetid/Makefile
    +++ b/tools/testing/selftests/safesetid/Makefile
    @@ -1,6 +1,7 @@
    # SPDX-License-Identifier: GPL-2.0
    # Makefile for mount selftests.
    -CFLAGS = -Wall -lcap -O2
    +CFLAGS = -Wall -O2
    +LDLIBS = -lcap

    TEST_PROGS := run_tests.sh
    TEST_GEN_FILES := safesetid-test
    --
    2.20.1
    \
     
     \ /
      Last update: 2019-12-27 18:57    [W:3.835 / U:0.024 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site