lkml.org 
[lkml]   [2019]   [Dec]   [25]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    /
    Date
    From
    SubjectRe: [PATCH 4/5] spi: uniphier: Add SPI_LOOP to the capabilities
    Hi Mark,
    Thanks for your comment.

    On Wed, 25 Dec 2019 18:01:42 +0000 <broonie@kernel.org> wrote:
    > On Tue, Dec 24, 2019 at 09:58:26AM +0900, Kunihiko Hayashi wrote:
    > > Add SPI_LOOP to the capabilities to support loopback mode.
    >
    > > master->min_speed_hz = DIV_ROUND_UP(clk_rate, SSI_MAX_CLK_DIVIDER);
    > > - master->mode_bits = SPI_CPOL | SPI_CPHA | SPI_CS_HIGH | SPI_LSB_FIRST;
    > > + master->mode_bits = SPI_CPOL | SPI_CPHA | SPI_CS_HIGH | SPI_LSB_FIRST |
    > > + SPI_LOOP;
    >
    > I'd expect to see a matching change that configures the hardware
    > in loopback mode when the driver is in SPI_MODE? There's nothing
    > in the existing driver.

    I see. When doing loopback test using spi-loopback-test.c, I thought
    'loop_req=1' option was needed, however, the controller doesn't need it.
    We can ignore this patch.

    Thank you,

    ---
    Best Regards,
    Kunihiko Hayashi

    \
     
     \ /
      Last update: 2019-12-26 02:56    [W:5.916 / U:0.172 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site