lkml.org 
[lkml]   [2019]   [Dec]   [23]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH 1/3] arm64: dts: sc7180: Add Venus video codec DT node
Hi Stan,

Thanks for the review!
I will address all the comments in the next version.

On 2019-12-20 15:04, Stanimir Varbanov wrote:
> Hi Dikshita,
>
> Thanks for the patch.
>
> On 12/20/19 9:59 AM, Dikshita Agarwal wrote:
>> This adds Venus video codec DT node for sc7180.
>>
>> Signed-off-by: Dikshita Agarwal <dikshita@codeaurora.org>
>> ---
>> arch/arm64/boot/dts/qcom/sc7180.dtsi | 36
>> ++++++++++++++++++++++++++++++++++++
>> 1 file changed, 36 insertions(+)
>>
>> diff --git a/arch/arm64/boot/dts/qcom/sc7180.dtsi
>> b/arch/arm64/boot/dts/qcom/sc7180.dtsi
>> index 6876aae2..42c70f5 100644
>> --- a/arch/arm64/boot/dts/qcom/sc7180.dtsi
>> +++ b/arch/arm64/boot/dts/qcom/sc7180.dtsi
>> @@ -10,6 +10,7 @@
>> #include <dt-bindings/interrupt-controller/arm-gic.h>
>> #include <dt-bindings/phy/phy-qcom-qusb2.h>
>> #include <dt-bindings/soc/qcom,rpmh-rsc.h>
>> +#include <dt-bindings/clock/qcom,videocc-sc7180.h>
>>
>> / {
>> interrupt-parent = <&intc>;
>> @@ -66,6 +67,11 @@
>> compatible = "qcom,cmd-db";
>> no-map;
>> };
>> +
>> + venus_mem: memory@8F600000 {
>> + reg = <0 0x8F600000 0 0x500000>;
>
> Please use lower-case for hex numbers.
>
>> + no-map;
>> + };
>> };
>>
>> cpus {
>> @@ -1042,6 +1048,36 @@
>> };
>> };
>>
>> + venus: video-codec@aa00000 {
>> + compatible = "qcom,sc7180-venus";
>> + reg = <0 0x0aa00000 0 0xff000>;
>> + interrupts = <GIC_SPI 174 IRQ_TYPE_LEVEL_HIGH>;
>> + power-domains = <&videocc VENUS_GDSC>,
>> + <&videocc VCODEC0_GDSC>;
>> + power-domain-names = "venus", "vcodec0";
>> + clocks = <&videocc VIDEO_CC_VENUS_CTL_CORE_CLK>,
>> + <&videocc VIDEO_CC_VENUS_AHB_CLK>,
>> + <&videocc VIDEO_CC_VENUS_CTL_AXI_CLK>,
>> + <&videocc VIDEO_CC_VCODEC0_CORE_CLK>,
>> + <&videocc VIDEO_CC_VCODEC0_AXI_CLK>;
>
> could you align those entries to the first one (you can use tabs and
> after that spaces to align)
>
>> + clock-names = "core", "iface", "bus",
>> + "vcodec0_core", "vcodec0_bus";
>> + iommus = <&apps_smmu 0x0C00 0x60>;
>
> lower-case please
>
>> + memory-region = <&venus_mem>;
>> +
>> + video-core0 {
>> + compatible = "venus-decoder";
>
> something is wrong with the indentation?
>
> Please run checkpatch with --strict
>
>> + };
>> +
>> + video-core1 {
>> + compatible = "venus-encoder";
>> + };
>> +
>> + video-firmware {
>> + iommus = <&apps_smmu 0x0C42 0x0>;
>
> lower-case
>
>> + };
>
> This subnode should be in sc7180-idp.dts, because we assume that by
> default the qcom platforms have TZ.
>
>> + };
>> +
>> pdc: interrupt-controller@b220000 {
>> compatible = "qcom,sc7180-pdc", "qcom,pdc";
>> reg = <0 0x0b220000 0 0x30000>;
>>

\
 
 \ /
  Last update: 2019-12-23 10:50    [W:0.152 / U:0.240 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site