Messages in this thread | | | Date | Fri, 20 Dec 2019 09:43:03 +0100 | From | Joerg Roedel <> | Subject | Re: [PATCH v4 03/16] PCI/ATS: Restore EXPORT_SYMBOL_GPL() for pci_{enable,disable}_ats() |
| |
Hi Bjorn,
On Thu, Dec 19, 2019 at 12:03:39PM +0000, Will Deacon wrote: > From: Greg Kroah-Hartman <gregkh@google.com> > > Commit d355bb209783 ("PCI/ATS: Remove unnecessary EXPORT_SYMBOL_GPL()") > unexported a bunch of symbols from the PCI core since the only external > users were non-modular IOMMU drivers. Although most of those symbols > can remain private for now, 'pci_{enable,disable_ats()' is required for > the ARM SMMUv3 driver to build as a module, otherwise we get a build > failure as follows: > > | ERROR: "pci_enable_ats" [drivers/iommu/arm-smmu-v3.ko] undefined! > | ERROR: "pci_disable_ats" [drivers/iommu/arm-smmu-v3.ko] undefined! > > Re-export these two functions so that the ARM SMMUv3 driver can be build > as a module. > > Cc: Bjorn Helgaas <bhelgaas@google.com> > Cc: Joerg Roedel <jroedel@suse.de> > Signed-off-by: Greg Kroah-Hartman <gregkh@google.com> > [will: rewrote commit message] > Signed-off-by: Will Deacon <will@kernel.org> > --- > drivers/pci/ats.c | 2 ++ > 1 file changed, 2 insertions(+)
Are you fine with this change? I would apply this series to my tree then.
Regards,
Joerg
| |