lkml.org 
[lkml]   [2019]   [Dec]   [19]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    Patch in this message
    /
    From
    Subject[PATCH 4.9 109/199] USB: idmouse: fix interface sanity checks
    Date
    From: Johan Hovold <johan@kernel.org>

    commit 59920635b89d74b9207ea803d5e91498d39e8b69 upstream.

    Make sure to use the current alternate setting when verifying the
    interface descriptors to avoid binding to an invalid interface.

    Failing to do so could cause the driver to misbehave or trigger a WARN()
    in usb_submit_urb() that kernels with panic_on_warn set would choke on.

    Fixes: 1da177e4c3f4 ("Linux-2.6.12-rc2")
    Cc: stable <stable@vger.kernel.org>
    Signed-off-by: Johan Hovold <johan@kernel.org>
    Link: https://lore.kernel.org/r/20191210112601.3561-4-johan@kernel.org
    Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>

    ---
    drivers/usb/misc/idmouse.c | 2 +-
    1 file changed, 1 insertion(+), 1 deletion(-)

    --- a/drivers/usb/misc/idmouse.c
    +++ b/drivers/usb/misc/idmouse.c
    @@ -342,7 +342,7 @@ static int idmouse_probe(struct usb_inte
    int result;

    /* check if we have gotten the data or the hid interface */
    - iface_desc = &interface->altsetting[0];
    + iface_desc = interface->cur_altsetting;
    if (iface_desc->desc.bInterfaceClass != 0x0A)
    return -ENODEV;


    \
     
     \ /
      Last update: 2019-12-19 19:46    [W:4.134 / U:0.128 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site