Messages in this thread | | | From | Andy Shevchenko <> | Date | Wed, 18 Dec 2019 19:59:43 +0200 | Subject | Re: [PATCH v3] platform/mellanox: fix the mlx-bootctl sysfs |
| |
On Wed, Dec 18, 2019 at 5:25 PM Liming Sun <lsun@mellanox.com> wrote: > > This is a follow-up commit for the sysfs attributes to change > from DRIVER_ATTR to DEVICE_ATTR according to some initial comments. > In such case, it's better to point the sysfs path to the device > itself instead of the driver. The ABI document is also updated. > > Fixes: 79e29cb8fbc5 ("platform/mellanox: Add bootctl driver for Mellanox BlueField Soc") > Signed-off-by: Liming Sun <lsun@mellanox.com>
...
> -ATTRIBUTE_GROUPS(mlxbf_bootctl);
What's wrong with above macro?
> +static const struct attribute_group mlxbf_bootctl_group = { > + .attrs = mlxbf_bootctl_attrs, > +};
...
> +static const struct attribute_group *mlxbf_bootctl_dev_groups[] = { > + &mlxbf_bootctl_group, > + NULL > +};
-- With Best Regards, Andy Shevchenko
| |