Messages in this thread | | | Date | Tue, 17 Dec 2019 22:29:06 -0800 | From | Bjorn Andersson <> | Subject | Re: [PATCH] phy: qualcomm: Adjust indentation in read_poll_timeout |
| |
On Tue 17 Dec 17:36 PST 2019, Nathan Chancellor wrote:
> Clang warns: > > ../drivers/phy/qualcomm/phy-qcom-apq8064-sata.c:83:4: warning: > misleading indentation; statement is not part of the previous 'if' > [-Wmisleading-indentation] > usleep_range(DELAY_INTERVAL_US, DELAY_INTERVAL_US + 50); > ^ > ../drivers/phy/qualcomm/phy-qcom-apq8064-sata.c:80:3: note: previous > statement is here > if (readl_relaxed(addr) & mask) > ^ > 1 warning generated. > > This warning occurs because there is a space after the tab on this line. > Remove it so that the indentation is consistent with the Linux kernel > coding style and clang no longer warns. >
Reviewed-by: Bjorn Andersson <bjorn.andersson@linaro.org>
> Fixes: 1de990d8a169 ("phy: qcom: Add driver for QCOM APQ8064 SATA PHY") > Link: https://github.com/ClangBuiltLinux/linux/issues/816 > Signed-off-by: Nathan Chancellor <natechancellor@gmail.com> > --- > drivers/phy/qualcomm/phy-qcom-apq8064-sata.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/drivers/phy/qualcomm/phy-qcom-apq8064-sata.c b/drivers/phy/qualcomm/phy-qcom-apq8064-sata.c > index 42bc5150dd92..febe0aef68d4 100644 > --- a/drivers/phy/qualcomm/phy-qcom-apq8064-sata.c > +++ b/drivers/phy/qualcomm/phy-qcom-apq8064-sata.c > @@ -80,7 +80,7 @@ static int read_poll_timeout(void __iomem *addr, u32 mask) > if (readl_relaxed(addr) & mask) > return 0; > > - usleep_range(DELAY_INTERVAL_US, DELAY_INTERVAL_US + 50); > + usleep_range(DELAY_INTERVAL_US, DELAY_INTERVAL_US + 50); > } while (!time_after(jiffies, timeout)); > > return (readl_relaxed(addr) & mask) ? 0 : -ETIMEDOUT; > -- > 2.24.1 >
| |