Messages in this thread | | | Subject | Re: [Patch v2] mm: remove dead code totalram_pages_set() | From | David Hildenbrand <> | Date | Wed, 18 Dec 2019 09:46:58 +0100 |
| |
On 18.12.19 01:55, Wei Yang wrote: > No one uses totalram_pages_set(), just remove it. > > Fixes: ca79b0c211af ("mm: convert totalram_pages and totalhigh_pages > variables to atomic")
Hi Wei, thanks for the update.
We should really avoid "Fixes" tags here. This is neither a bugfix nor a compile fix.
@Andrew, can you fix that up to: "Last user was removed in commit ca79b0c211af ("mm: convert totalram_pages and totalhigh_pages variables to atomic")."
Cheers!
> > Signed-off-by: Wei Yang <richardw.yang@linux.intel.com> > Reviewed-by: David Hildenbrand <david@redhat.com> > > --- > v2: fix typo and points which commit introduce it. > --- > include/linux/mm.h | 5 ----- > 1 file changed, 5 deletions(-) > > diff --git a/include/linux/mm.h b/include/linux/mm.h > index 74232b28949b..4cf023c4c6b3 100644 > --- a/include/linux/mm.h > +++ b/include/linux/mm.h > @@ -70,11 +70,6 @@ static inline void totalram_pages_add(long count) > atomic_long_add(count, &_totalram_pages); > } > > -static inline void totalram_pages_set(long val) > -{ > - atomic_long_set(&_totalram_pages, val); > -} > - > extern void * high_memory; > extern int page_cluster; > >
-- Thanks,
David / dhildenb
| |