Messages in this thread | | | Subject | Re: [PATCH v1 2/4] scsi: ufs: export ufshcd_auto_hibern8_update for vendor usage | From | "Asutosh Das (asd)" <> | Date | Wed, 18 Dec 2019 15:53:37 -0800 |
| |
On 12/13/2019 12:11 AM, Stanley Chu wrote: > Export ufshcd_auto_hibern8_update to allow vendors to use common > interface to customize auto-hibernate timer. > > Signed-off-by: Stanley Chu <stanley.chu@mediatek.com> > --- > drivers/scsi/ufs/ufs-sysfs.c | 20 -------------------- > drivers/scsi/ufs/ufshcd.c | 18 ++++++++++++++++++ > drivers/scsi/ufs/ufshcd.h | 1 + > 3 files changed, 19 insertions(+), 20 deletions(-) > > diff --git a/drivers/scsi/ufs/ufs-sysfs.c b/drivers/scsi/ufs/ufs-sysfs.c > index ad2abc96c0f1..720be3f64be7 100644 > --- a/drivers/scsi/ufs/ufs-sysfs.c > +++ b/drivers/scsi/ufs/ufs-sysfs.c > @@ -118,26 +118,6 @@ static ssize_t spm_target_link_state_show(struct device *dev, > ufs_pm_lvl_states[hba->spm_lvl].link_state)); > } > > -static void ufshcd_auto_hibern8_update(struct ufs_hba *hba, u32 ahit) > -{ > - unsigned long flags; > - > - if (!ufshcd_is_auto_hibern8_supported(hba)) > - return; > - > - spin_lock_irqsave(hba->host->host_lock, flags); > - if (hba->ahit != ahit) > - hba->ahit = ahit; > - spin_unlock_irqrestore(hba->host->host_lock, flags); > - if (!pm_runtime_suspended(hba->dev)) { > - pm_runtime_get_sync(hba->dev); > - ufshcd_hold(hba, false); > - ufshcd_auto_hibern8_enable(hba); > - ufshcd_release(hba); > - pm_runtime_put(hba->dev); > - } > -} > - > /* Convert Auto-Hibernate Idle Timer register value to microseconds */ > static int ufshcd_ahit_to_us(u32 ahit) > { > diff --git a/drivers/scsi/ufs/ufshcd.c b/drivers/scsi/ufs/ufshcd.c > index b5966faf3e98..589f519316aa 100644 > --- a/drivers/scsi/ufs/ufshcd.c > +++ b/drivers/scsi/ufs/ufshcd.c > @@ -3956,6 +3956,24 @@ static int ufshcd_uic_hibern8_exit(struct ufs_hba *hba) > return ret; > } > > +void ufshcd_auto_hibern8_update(struct ufs_hba *hba, u32 ahit) > +{ > + unsigned long flags; > + > + if (!(hba->capabilities & MASK_AUTO_HIBERN8_SUPPORT)) > + return; > + > + spin_lock_irqsave(hba->host->host_lock, flags); > + if (hba->ahit == ahit) > + goto out_unlock; > + hba->ahit = ahit; > + if (!pm_runtime_suspended(hba->dev)) > + ufshcd_writel(hba, hba->ahit, REG_AUTO_HIBERNATE_IDLE_TIMER); > +out_unlock: > + spin_unlock_irqrestore(hba->host->host_lock, flags); > +} > +EXPORT_SYMBOL_GPL(ufshcd_auto_hibern8_update); > + > void ufshcd_auto_hibern8_enable(struct ufs_hba *hba) > { > unsigned long flags; > diff --git a/drivers/scsi/ufs/ufshcd.h b/drivers/scsi/ufs/ufshcd.h > index 2740f6941ec6..86586a0b9aa5 100644 > --- a/drivers/scsi/ufs/ufshcd.h > +++ b/drivers/scsi/ufs/ufshcd.h > @@ -927,6 +927,7 @@ int ufshcd_query_flag(struct ufs_hba *hba, enum query_opcode opcode, > enum flag_idn idn, bool *flag_res); > > void ufshcd_auto_hibern8_enable(struct ufs_hba *hba); > +void ufshcd_auto_hibern8_update(struct ufs_hba *hba, u32 ahit); > > #define SD_ASCII_STD true > #define SD_RAW false >
Looks good to me.
Reviewed-by: Asutosh Das <asutoshd@codeaurora.org>
-- The Qualcomm Innovation Center, Inc. is a member of the Code Aurora Forum, Linux Foundation Collaborative Project
| |