Messages in this thread Patch in this message | | | From | Paul Gortmaker <> | Subject | [PATCH 12/18] mfd: lp8788: Make it explicitly non-modular | Date | Wed, 18 Dec 2019 15:48:51 -0500 |
| |
The Kconfig currently controlling compilation of this code is:
drivers/mfd/Kconfig:config MFD_LP8788 drivers/mfd/Kconfig: bool "TI LP8788 Power Management Unit Driver"
...meaning that it currently is not being built as a module by anyone.
Lets remove the modular code that is essentially orphaned, so that when reading the driver there is no doubt it is builtin-only.
We explicitly disallow a driver unbind, since that doesn't have a sensible use case anyway, and it allows us to drop the ".remove" code for non-modular drivers.
Since module_init was not in use by this code, the init ordering remains unchanged with this commit.
Also note that MODULE_DEVICE_TABLE is a no-op for non-modular code.
We also delete the MODULE_LICENSE tag etc. since all that information is already contained at the top of the file in the comments.
Cc: Milo Kim <milo.kim@ti.com> Cc: Lee Jones <lee.jones@linaro.org> Signed-off-by: Paul Gortmaker <paul.gortmaker@windriver.com> --- drivers/mfd/lp8788.c | 24 ++---------------------- 1 file changed, 2 insertions(+), 22 deletions(-)
diff --git a/drivers/mfd/lp8788.c b/drivers/mfd/lp8788.c index 768d556b3fe9..b218855e4162 100644 --- a/drivers/mfd/lp8788.c +++ b/drivers/mfd/lp8788.c @@ -11,7 +11,7 @@ #include <linux/i2c.h> #include <linux/mfd/core.h> #include <linux/mfd/lp8788.h> -#include <linux/module.h> +#include <linux/init.h> #include <linux/slab.h> #define MAX_LP8788_REGISTERS 0xA2 @@ -199,27 +199,17 @@ static int lp8788_probe(struct i2c_client *cl, const struct i2c_device_id *id) ARRAY_SIZE(lp8788_devs), NULL, 0, NULL); } -static int lp8788_remove(struct i2c_client *cl) -{ - struct lp8788 *lp = i2c_get_clientdata(cl); - - mfd_remove_devices(lp->dev); - lp8788_irq_exit(lp); - return 0; -} - static const struct i2c_device_id lp8788_ids[] = { {"lp8788", 0}, { } }; -MODULE_DEVICE_TABLE(i2c, lp8788_ids); static struct i2c_driver lp8788_driver = { .driver = { .name = "lp8788", + .suppress_bind_attrs = true, }, .probe = lp8788_probe, - .remove = lp8788_remove, .id_table = lp8788_ids, }; @@ -228,13 +218,3 @@ static int __init lp8788_init(void) return i2c_add_driver(&lp8788_driver); } subsys_initcall(lp8788_init); - -static void __exit lp8788_exit(void) -{ - i2c_del_driver(&lp8788_driver); -} -module_exit(lp8788_exit); - -MODULE_DESCRIPTION("TI LP8788 MFD Driver"); -MODULE_AUTHOR("Milo Kim"); -MODULE_LICENSE("GPL"); -- 2.7.4
| |