Messages in this thread | | | Subject | Re: [PATCH] mt76: fix LED link time failure | From | Felix Fietkau <> | Date | Tue, 17 Dec 2019 15:59:22 +0100 |
| |
On 2019-12-17 15:35, Kalle Valo wrote: > Arnd Bergmann <arnd@arndb.de> writes: > >> The mt76_led_cleanup() function is called unconditionally, which >> leads to a link error when CONFIG_LEDS is a loadable module or >> disabled but mt76 is built-in: >> >> drivers/net/wireless/mediatek/mt76/mac80211.o: In function `mt76_unregister_device': >> mac80211.c:(.text+0x2ac): undefined reference to `led_classdev_unregister' >> >> Use the same trick that is guarding the registration, using an >> IS_ENABLED() check for the CONFIG_MT76_LEDS symbol that indicates >> whether LEDs can be used or not. >> >> Fixes: 36f7e2b2bb1d ("mt76: do not use devm API for led classdev") >> Signed-off-by: Arnd Bergmann <arnd@arndb.de> > > Felix, as this is a regression in v5.5-rc1 can I take this directly to > wireless-drivers? Yes. Please add: Acked-by: Felix Fietkau <nbd@nbd.name>
- Felix
| |