Messages in this thread | | | Date | Tue, 17 Dec 2019 07:42:54 +0100 | From | Dominik Brodowski <> | Subject | Re: [PATCH 4/5] init: unify opening /dev/console as stdin/stdout/stderr |
| |
On Tue, Dec 17, 2019 at 01:17:51PM +0800, youling257 wrote: > it caused Androidx86 /system/bin/sh: No controlling tty: open /dev/tty: No such device or address > /system/bin/sh: warning: won't have full job control > > Androidx86 alt+f1 root on tmpfs, alt+f2/f3 root on rootfs.
Are you sure it is caused by the patch you reference? It's really only moving code around, and does not depend on tmpfs/rootfs. The exact same three calls are made before and after the change, see https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/commit/?id=b49a733d684e0096340b93e9dfd471f0e3ddc06d
The preceding patch (3/5) needs a bugfix which already is upstream, though. https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/commit/?id=7de7de7ca0ae0fc70515ee3154af33af75edae2c
Thanks, Dominik
| |