lkml.org 
[lkml]   [2019]   [Dec]   [16]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    Patch in this message
    /
    From
    Subject[PATCH 4.14 197/267] md/raid0: Fix an error message in raid0_make_request()
    Date
    From: Dan Carpenter <dan.carpenter@oracle.com>

    [ Upstream commit e3fc3f3d0943b126f76b8533960e4168412d9e5a ]

    The first argument to WARN() is supposed to be a condition. The
    original code will just print the mdname() instead of the full warning
    message.

    Fixes: c84a1372df92 ("md/raid0: avoid RAID0 data corruption due to layout confusion.")
    Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com>
    Signed-off-by: Song Liu <songliubraving@fb.com>
    Signed-off-by: Sasha Levin <sashal@kernel.org>
    ---
    drivers/md/raid0.c | 2 +-
    1 file changed, 1 insertion(+), 1 deletion(-)

    diff --git a/drivers/md/raid0.c b/drivers/md/raid0.c
    index 449c4dd060fcd..204adde004a3c 100644
    --- a/drivers/md/raid0.c
    +++ b/drivers/md/raid0.c
    @@ -616,7 +616,7 @@ static bool raid0_make_request(struct mddev *mddev, struct bio *bio)
    tmp_dev = map_sector(mddev, zone, sector, &sector);
    break;
    default:
    - WARN("md/raid0:%s: Invalid layout\n", mdname(mddev));
    + WARN(1, "md/raid0:%s: Invalid layout\n", mdname(mddev));
    bio_io_error(bio);
    return true;
    }
    --
    2.20.1


    \
     
     \ /
      Last update: 2019-12-16 18:59    [W:3.568 / U:0.172 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site