lkml.org 
[lkml]   [2019]   [Dec]   [16]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH] Re: memory leak in reiserfs_fill_super
On Sat 14-12-19 15:12:57, Randy Dunlap wrote:
> From: Randy Dunlap <rdunlap@infradead.org>
>
> fill_super() conditionally allocates a jdev string if "jdev=x"
> is specified. put_super() should free that memory.
>
> Reported-by: syzbot+1c6756baf4b16b94d2a6@syzkaller.appspotmail.com
> Signed-off-by: Randy Dunlap <rdunlap@infradead.org>

Thanks Randy but I've already sent a similar (and more complete) fix to this
bug as part of [1].

Honza

[1] https://lore.kernel.org/linux-fsdevel/20191212105018.910-1-jack@suse.cz/

> ---
> fs/reiserfs/super.c | 1 +
> 1 file changed, 1 insertion(+)
>
> --- linux-next-20191213.orig/fs/reiserfs/super.c
> +++ linux-next-20191213/fs/reiserfs/super.c
> @@ -629,6 +629,7 @@ static void reiserfs_put_super(struct su
> reiserfs_write_unlock(s);
> mutex_destroy(&REISERFS_SB(s)->lock);
> destroy_workqueue(REISERFS_SB(s)->commit_wq);
> + kfree(REISERFS_SB(s)->s_jdev);
> kfree(s->s_fs_info);
> s->s_fs_info = NULL;
> }
>
--
Jan Kara <jack@suse.com>
SUSE Labs, CR

\
 
 \ /
  Last update: 2019-12-16 12:58    [W:0.040 / U:1.388 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site