lkml.org 
[lkml]   [2019]   [Dec]   [16]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    /
    Date
    From
    SubjectRe: 答复: [PATCH][v2 ] page_pool: handle page recycle for NUMA_NO_NODE condition
    > > > 
    > > > Simply clearing the pool->alloc.cache when calling page_pool_update_nid()
    > > > seems better.
    > > >
    > >
    > > How about the below codes, the driver can configure p.nid to any, which will be adjusted in NAPI polling, irq migration will not be problem, but it will add a check into hot path.
    >
    > We'll have to check the impact on some high speed (i.e 100gbit) interface
    > between doing anything like that. Saeed's current patch runs once per NAPI. This
    > runs once per packet. The load might be measurable.
    > The READ_ONCE is needed in case all producers/consumers run on the same CPU

    I meant different cpus!

    > right?
    >
    >
    > Thanks
    > /Ilias
    > >
    > > diff --git a/net/core/page_pool.c b/net/core/page_pool.c
    > > index a6aefe989043..4374a6239d17 100644
    > > --- a/net/core/page_pool.c
    > > +++ b/net/core/page_pool.c
    > > @@ -108,6 +108,10 @@ static struct page *__page_pool_get_cached(struct page_pool *pool)
    > > if (likely(pool->alloc.count)) {
    > > /* Fast-path */
    > > page = pool->alloc.cache[--pool->alloc.count];
    > > +
    > > + if (unlikely(READ_ONCE(pool->p.nid) != numa_mem_id()))
    > > + WRITE_ONCE(pool->p.nid, numa_mem_id());
    > > +
    > > return page;
    > > }
    > > refill = true;
    > > @@ -155,6 +159,10 @@ static struct page *__page_pool_alloc_pages_slow(struct page_pool *pool,
    > > if (pool->p.order)
    > > gfp |= __GFP_COMP;
    > >
    > > +
    > > + if (unlikely(READ_ONCE(pool->p.nid) != numa_mem_id()))
    > > + WRITE_ONCE(pool->p.nid, numa_mem_id());
    > > +
    > > /* FUTURE development:
    > > *
    > > * Current slow-path essentially falls back to single page
    > > Thanks
    > >
    > > -Li
    > > > >
    > >

    \
     
     \ /
      Last update: 2019-12-16 11:17    [W:3.494 / U:0.664 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site