lkml.org 
[lkml]   [2019]   [Dec]   [16]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    Patch in this message
    /
    From
    Subject[PATCH 4.14 013/267] audit_get_nd(): dont unlock parent too early
    Date
    From: Al Viro <viro@zeniv.linux.org.uk>

    [ Upstream commit 69924b89687a2923e88cc42144aea27868913d0e ]

    if the child has been negative and just went positive
    under us, we want coherent d_is_positive() and ->d_inode.
    Don't unlock the parent until we'd done that work...

    Signed-off-by: Al Viro <viro@zeniv.linux.org.uk>
    Signed-off-by: Sasha Levin <sashal@kernel.org>
    ---
    kernel/audit_watch.c | 2 +-
    1 file changed, 1 insertion(+), 1 deletion(-)

    diff --git a/kernel/audit_watch.c b/kernel/audit_watch.c
    index 4a98f6e314a9b..35f1d706bd5b4 100644
    --- a/kernel/audit_watch.c
    +++ b/kernel/audit_watch.c
    @@ -365,12 +365,12 @@ static int audit_get_nd(struct audit_watch *watch, struct path *parent)
    struct dentry *d = kern_path_locked(watch->path, parent);
    if (IS_ERR(d))
    return PTR_ERR(d);
    - inode_unlock(d_backing_inode(parent->dentry));
    if (d_is_positive(d)) {
    /* update watch filter fields */
    watch->dev = d->d_sb->s_dev;
    watch->ino = d_backing_inode(d)->i_ino;
    }
    + inode_unlock(d_backing_inode(parent->dentry));
    dput(d);
    return 0;
    }
    --
    2.20.1


    \
     
     \ /
      Last update: 2019-12-16 19:52    [W:2.543 / U:0.008 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site