Messages in this thread Patch in this message | | | Subject | Re: [RFC PATCH v6 0/7] Speed booting by sorting ORC unwind tables at build time | From | Shile Zhang <> | Date | Mon, 16 Dec 2019 11:07:29 +0800 |
| |
On 2019/12/13 18:02, Ingo Molnar wrote: > arch/x86/kernel/unwind_orc.c:210:12: warning: ‘orc_sort_cmp’ defined but not used [-Wunused-function] > arch/x86/kernel/unwind_orc.c:190:13: warning: ‘orc_sort_swap’ defined but not used [-Wunused-function] Hi Ingo,
Sorry for trouble! please help to check the warning-fix patch. Thanks!
--- From b3d34213b4fe5a9cf2efcc1c758a5fb6c5f7676b Mon Sep 17 00:00:00 2001 From: Shile Zhang <shile.zhang@linux.alibaba.com> Date: Mon, 16 Dec 2019 10:56:03 +0800 Subject: [PATCH] x86/unwind/orc: fix build warning MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit
To fix follwowing warning due to ORC sort moved to build time:
arch/x86/kernel/unwind_orc.c:210:12: warning: ‘orc_sort_cmp’ defined but not used [-Wunused-function] arch/x86/kernel/unwind_orc.c:190:13: warning: ‘orc_sort_swap’ defined but not used [-Wunused-function]
Signed-off-by: Shile Zhang <shile.zhang@linux.alibaba.com> --- arch/x86/kernel/unwind_orc.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/arch/x86/kernel/unwind_orc.c b/arch/x86/kernel/unwind_orc.c index 280da6fa9922..2391874b724a 100644 --- a/arch/x86/kernel/unwind_orc.c +++ b/arch/x86/kernel/unwind_orc.c @@ -187,6 +187,7 @@ static struct orc_entry *orc_find(unsigned long ip) return orc_ftrace_find(ip); }
+#ifdef CONFIG_MODULES static void orc_sort_swap(void *_a, void *_b, int size) { struct orc_entry *orc_a, *orc_b; @@ -229,7 +230,6 @@ static int orc_sort_cmp(const void *_a, const void *_b) return orc_a->sp_reg == ORC_REG_UNDEFINED && !orc_a->end ? -1 : 1; }
-#ifdef CONFIG_MODULES void unwind_module_init(struct module *mod, void *_orc_ip, size_t orc_ip_size, void *_orc, size_t orc_size) { -- 2.24.0.rc2
| |