Messages in this thread | | | Subject | Re: [PATCH v2] io_uring: don't wait when under-submitting | From | Pavel Begunkov <> | Date | Sat, 14 Dec 2019 17:44:23 +0300 |
| |
On 14/12/2019 17:39, Jens Axboe wrote: > On 12/14/19 7:31 AM, Pavel Begunkov wrote: >> There is no reliable way to submit and wait in a single syscall, as >> io_submit_sqes() may under-consume sqes (in case of an early error). >> Then it will wait for not-yet-submitted requests, deadlocking the user >> in most cases. >> >> Don't wait/poll if can't submit all sqes, and return -EAGAIN >> >> Signed-off-by: Pavel Begunkov <asml.silence@gmail.com> >> --- >> >> v2: cap min_complete if submitted partially (Jens Axboe) > > Can you update the commit message as well, doesn't really reflect the > current state of it... Apart from that, looks good to me! > Right, thanks for noticing!
-- Pavel Begunkov
[unhandled content-type:application/pgp-signature] | |