Messages in this thread | | | Subject | Re: [PATCH] platform/chrome: cros_ec_lpc: Use platform_get_irq_optional() for optional IRQs | From | Enric Balletbo i Serra <> | Date | Sat, 14 Dec 2019 12:53:11 +0100 |
| |
Hi,
On 29/11/19 16:56, Guenter Roeck wrote: > On Fri, Nov 29, 2019 at 2:23 AM Enric Balletbo i Serra > <enric.balletbo@collabora.com> wrote: >> >> As platform_get_irq() now prints an error when the interrupt does not >> exist, use platform_get_irq_optional() to get the IRQ which is optional >> to avoid below error message during probe: >> >> [ 5.113502] cros_ec_lpcs GOOG0004:00: IRQ index 0 not found >> >> Signed-off-by: Enric Balletbo i Serra <enric.balletbo@collabora.com> > > Reviewed-by: Guenter Roeck <groeck@chromium.org> >
Queued for 5.6.
>> --- >> >> drivers/platform/chrome/cros_ec_lpc.c | 2 +- >> 1 file changed, 1 insertion(+), 1 deletion(-) >> >> diff --git a/drivers/platform/chrome/cros_ec_lpc.c b/drivers/platform/chrome/cros_ec_lpc.c >> index dccf479c6625..ffdea7c347f2 100644 >> --- a/drivers/platform/chrome/cros_ec_lpc.c >> +++ b/drivers/platform/chrome/cros_ec_lpc.c >> @@ -396,7 +396,7 @@ static int cros_ec_lpc_probe(struct platform_device *pdev) >> * Some boards do not have an IRQ allotted for cros_ec_lpc, >> * which makes ENXIO an expected (and safe) scenario. >> */ >> - irq = platform_get_irq(pdev, 0); >> + irq = platform_get_irq_optional(pdev, 0); >> if (irq > 0) >> ec_dev->irq = irq; >> else if (irq != -ENXIO) { >> -- >> 2.20.1 >> >
| |