Messages in this thread | | | Subject | Re: [PATCH v2] mm/gup: Fix memory leak in __gup_benchmark_ioctl | From | Markus Elfring <> | Date | Sat, 14 Dec 2019 19:10:55 +0100 |
| |
… > +++ b/mm/gup_benchmark.c … > @@ -85,8 +85,9 @@ static int __gup_benchmark_ioctl(unsigned int cmd, > end_time = ktime_get(); > gup->put_delta_usec = ktime_us_delta(end_time, start_time); > > +done: > kvfree(pages); > - return 0; > + return ret; > } > > static long gup_benchmark_ioctl(struct file *filep, unsigned int cmd,
Can the addition of a label like “free_pages” be more appropriate here?
Regards, Markus
| |