Messages in this thread | | | Date | Fri, 13 Dec 2019 15:06:31 -0600 | From | Bjorn Helgaas <> | Subject | Re: [v2 1/6] pci: pcie-rcar: preparation for adding endpoint support |
| |
On Fri, Dec 13, 2019 at 08:47:43AM +0000, Lad Prabhakar wrote: > From: "Lad, Prabhakar" <prabhakar.mahadev-lad.rj@bp.renesas.com> > > this patch prepares for adding endpoint support to rcar controller, > there are no functional changes with this patch, a common file is > created so that it can be shared with endpoint driver. Alongside > this patch fixes checkpatch reported issues.
Can you please split this into:
- a patch that moves code only, with no other changes except any necessary Kconfig and Makefile changes - another patch that fixes the checkpatch things
When the checkpatch fixes are buried in the code move, it's impossible to review them.
> Signed-off-by: Lad, Prabhakar <prabhakar.mahadev-lad.rj@bp.renesas.com> > --- > arch/arm64/configs/defconfig | 2 +- > drivers/pci/controller/Kconfig | 4 +- > drivers/pci/controller/Makefile | 2 +- > drivers/pci/controller/pcie-rcar-host.c | 1056 ++++++++++++++++++++++++++ > drivers/pci/controller/pcie-rcar.c | 1229 ++----------------------------- > drivers/pci/controller/pcie-rcar.h | 129 ++++ > 6 files changed, 1242 insertions(+), 1180 deletions(-) > create mode 100644 drivers/pci/controller/pcie-rcar-host.c > create mode 100644 drivers/pci/controller/pcie-rcar.h
| |