Messages in this thread | | | From | Jim Quinlan <> | Date | Fri, 13 Dec 2019 10:33:41 -0500 | Subject | Re: [PATCH] spi: bcm2835: don't print error on clk_get() DEFER |
| |
On Fri, Dec 13, 2019 at 6:41 AM Mark Brown <broonie@kernel.org> wrote: > > On Thu, Dec 12, 2019 at 06:12:13PM -0500, Jim Quinlan wrote: > > Otherwise one may get multiple error messages for normal > > operation of a clock provider. > > > if (IS_ERR(bs->clk)) { > > err = PTR_ERR(bs->clk); > > - dev_err(&pdev->dev, "could not get clk: %d\n", err); > > + if (err != -EPROBE_DEFER) > > + dev_err(&pdev->dev, "could not get clk: %d\n", err); > > On the other hand if the clock isn't there and never appears then there > won't be anything saying why the driver isn't loading which won't be > helpful when trying to figure out what's going on.
Understood; I could do a dev_dbg() on -EPROBE_DEFER and dev_err() on all other errors -- would that work for you?
| |