Messages in this thread | | | Date | Fri, 13 Dec 2019 10:56:58 +0000 | From | Charles Keepax <> | Subject | Re: [alsa-devel] [PATCH] ASoC: wm8962: fix lambda value |
| |
On Fri, Dec 13, 2019 at 11:09:09AM +0800, Shengjiu Wang wrote: > Hi > > On Fri, Dec 13, 2019 at 12:54 AM Mark Brown <broonie@kernel.org> wrote: > > > > On Thu, Dec 12, 2019 at 04:48:35PM +0000, Charles Keepax wrote: > > > On Wed, Dec 11, 2019 at 07:57:22PM +0800, Shengjiu Wang wrote: > > > > According to user manual, it is required that FLL_LAMBDA > 0 > > > > in all cases (Integer and Franctional modes). > > > > > How well tested is this change, and is it addressing an issue you > > > have observed? I agree this does better fit the datasheet just a > > > little nervous as its an older part that has seen a lot of usage. > > > > I've got a feeling that requirement might've been added in later > > versions of the datasheet... > > We encounter an issue that when Integer mode, the lambda=theta=0, > the output sound is slower than expected. After change lambda=1 > the issue is gone. >
Cool alright if there is a real issue here, then we should be getting it fixed.
Acked-by: Charles Keepax <ckeepax@opensource.cirrus.com>
Thanks, Charles
| |