Messages in this thread | | | From | Doug Anderson <> | Date | Thu, 12 Dec 2019 08:09:08 -0800 | Subject | Re: [PATCH v2 1/1] arm64: dts: qcom: sc7180: Add device node support for TSENS in SC7180 |
| |
Hi,
On Thu, Dec 12, 2019 at 3:00 AM Amit Kucheria <amit.kucheria@verdurent.com> wrote: > > Hi Rajeshwari, > > On Thu, Nov 28, 2019 at 3:25 PM Rajeshwari <rkambl@codeaurora.org> wrote: > > > > Add TSENS node and user thermal zone for TSENS sensors in SC7180. > > > > Signed-off-by: Rajeshwari <rkambl@codeaurora.org> > > --- > > arch/arm64/boot/dts/qcom/sc7180.dtsi | 527 +++++++++++++++++++++++++++++++++++ > > 1 file changed, 527 insertions(+) > > > > diff --git a/arch/arm64/boot/dts/qcom/sc7180.dtsi b/arch/arm64/boot/dts/qcom/sc7180.dtsi > > index 666e9b9..6656ffc 100644 > > --- a/arch/arm64/boot/dts/qcom/sc7180.dtsi > > +++ b/arch/arm64/boot/dts/qcom/sc7180.dtsi > > @@ -911,6 +911,26 @@ > > status = "disabled"; > > }; > > > > + tsens0: thermal-sensor@c263000 { > > + compatible = "qcom,sc7180-tsens","qcom,tsens-v2"; > > + reg = <0 0x0c263000 0 0x1ff>, /* TM */ > > + <0 0x0c222000 0 0x1ff>; /* SROT */ > > + #qcom,sensors = <15>; > > + interrupts = <GIC_SPI 506 IRQ_TYPE_LEVEL_HIGH>; > > + interrupt-names = "uplow"; > > + #thermal-sensor-cells = <1>; > > + }; > > + > > + tsens1: thermal-sensor@c265000 { > > + compatible = "qcom,sc7180-tsens","qcom,tsens-v2"; > > + reg = <0 0x0c265000 0 0x1ff>, /* TM */ > > + <0 0x0c223000 0 0x1ff>; /* SROT */ > > + #qcom,sensors = <10>; > > + interrupts = <GIC_SPI 507 IRQ_TYPE_LEVEL_HIGH>; > > + interrupt-names = "uplow"; > > + #thermal-sensor-cells = <1>; > > + }; > > + > > spmi_bus: spmi@c440000 { > > compatible = "qcom,spmi-pmic-arb"; > > reg = <0 0x0c440000 0 0x1100>, > > @@ -1121,6 +1141,513 @@ > > }; > > }; > > > > + thermal-zones { > > + cpu0-thermal { > > + polling-delay-passive = <250>; > > + polling-delay = <1000>; > > + > > + thermal-sensors = <&tsens0 1>; > > + > > + trips { > > + cpu0_alert0: trip-point0 { > > + temperature = <90000>; > > + hysteresis = <2000>; > > + type = "passive"; > > + }; > > + > > + cpu0_alert1: trip-point1 { > > + temperature = <95000>; > > + hysteresis = <2000>; > > + type = "passive"; > > + }; > > + > > + cpu0_crit: cpu_crit { > > + temperature = <110000>; > > + hysteresis = <1000>; > > + type = "critical"; > > + }; > > Where are the cooling maps for all the cpu thermal zones? A passive > trip point w/o a cooling map is not of much use. If you are waiting > for cpufreq support to land before adding them, then remove the > passive trip points for now and add them along with the cooling maps > when you have cooling devices.
I will note that cpufreq support has landed in the qcom tree::
https://git.kernel.org/pub/scm/linux/kernel/git/qcom/linux.git/commit/?h=for-next&id=86899d8235ea0d3d7c293404fb43a6fabff866e6
...so I guess the right thing is to send a patch adding the cooling maps for the cpu thermal zones?
-Doug
| |