Messages in this thread | | | Date | Thu, 12 Dec 2019 17:03:12 +0100 | From | Greg KH <> | Subject | Re: [PATCH v2 11/23] staging: qlge: Fix CHECK: braces {} should be used on all arms of this statement |
| |
On Thu, Dec 12, 2019 at 09:02:00AM -0600, Scott Schafer wrote: > On Thu, Dec 12, 2019 at 03:12:06PM +0300, Dan Carpenter wrote: > > On Wed, Dec 11, 2019 at 12:12:40PM -0600, Scott Schafer wrote: > > > @@ -351,8 +352,9 @@ static int ql_aen_lost(struct ql_adapter *qdev, struct mbox_params *mbcp) > > > mbcp->out_count = 6; > > > > > > status = ql_get_mb_sts(qdev, mbcp); > > > - if (status) > > > + if (status) { > > > netif_err(qdev, drv, qdev->ndev, "Lost AEN broken!\n"); > > > + } > > > else { > > > > The close } should be on the same line as the else. > > > > > int i; > > > > > > > regards, > > dan carpenter > > this was fixed in patch 22
Don't add a warning that you later fix up :)
| |