Messages in this thread Patch in this message | | | From | Laura Abbott <> | Subject | [PATCH] vfs: Don't reject unknown parameters | Date | Thu, 12 Dec 2019 09:50:42 -0500 |
| |
The new mount API currently rejects unknown parameters if the filesystem doesn't have doesn't take any arguments. This is unfortunately a regression from the old API which silently ignores extra arguments. This is easly seen with the squashfs conversion (5a2be1288b51 ("vfs: Convert squashfs to use the new mount API")) which now fails to mount with extra options. Just get rid of the error.
Fixes: 3e1aeb00e6d1 ("vfs: Implement a filesystem superblock creation/configuration context") Link: https://lore.kernel.org/lkml/20191130181548.GA28459@gentoo-tp.home/ Reported-by: Jeremi Piotrowski <jeremi.piotrowski@gmail.com> Bugzilla: https://bugzilla.redhat.com/show_bug.cgi?id=1781863 Signed-off-by: Laura Abbott <labbott@redhat.com> --- fs/fs_context.c | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-)
diff --git a/fs/fs_context.c b/fs/fs_context.c index 138b5b4d621d..7ec20b1f8a53 100644 --- a/fs/fs_context.c +++ b/fs/fs_context.c @@ -160,8 +160,7 @@ int vfs_parse_fs_param(struct fs_context *fc, struct fs_parameter *param) return 0; } - return invalf(fc, "%s: Unknown parameter '%s'", - fc->fs_type->name, param->key); + return 0; } EXPORT_SYMBOL(vfs_parse_fs_param); -- 2.21.0
| |