Messages in this thread Patch in this message | | | From | Huang Shijie <> | Subject | [PATCH v4] lib/dynamic_debug: make better dynamic log output | Date | Thu, 12 Dec 2019 14:35:32 +0800 |
| |
The driver strings, device name and net device name are not changed for the driver's dynamic log output. But the dynamic_emit_prefix() which contains the function names may change when the function names are changed.
So the patch makes the better dynamic log output.
Signed-off-by: Huang Shijie <sjhuang@iluvatar.ai> --- v3 -- > v4: remove the duplicated colon. --- lib/dynamic_debug.c | 12 ++++++------ 1 file changed, 6 insertions(+), 6 deletions(-)
diff --git a/lib/dynamic_debug.c b/lib/dynamic_debug.c index c60409138e13..e375253c0c22 100644 --- a/lib/dynamic_debug.c +++ b/lib/dynamic_debug.c @@ -589,9 +589,9 @@ void __dynamic_dev_dbg(struct _ddebug *descriptor, } else { char buf[PREFIX_SIZE]; - dev_printk_emit(LOGLEVEL_DEBUG, dev, "%s%s %s: %pV", - dynamic_emit_prefix(descriptor, buf), + dev_printk_emit(LOGLEVEL_DEBUG, dev, "%s %s %s %pV", dev_driver_string(dev), dev_name(dev), + dynamic_emit_prefix(descriptor, buf), &vaf); } @@ -619,11 +619,11 @@ void __dynamic_netdev_dbg(struct _ddebug *descriptor, char buf[PREFIX_SIZE]; dev_printk_emit(LOGLEVEL_DEBUG, dev->dev.parent, - "%s%s %s %s%s: %pV", - dynamic_emit_prefix(descriptor, buf), + "%s %s %s %s %s %pV", dev_driver_string(dev->dev.parent), dev_name(dev->dev.parent), netdev_name(dev), netdev_reg_state(dev), + dynamic_emit_prefix(descriptor, buf), &vaf); } else if (dev) { printk(KERN_DEBUG "%s%s: %pV", netdev_name(dev), @@ -655,11 +655,11 @@ void __dynamic_ibdev_dbg(struct _ddebug *descriptor, char buf[PREFIX_SIZE]; dev_printk_emit(LOGLEVEL_DEBUG, ibdev->dev.parent, - "%s%s %s %s: %pV", - dynamic_emit_prefix(descriptor, buf), + "%s %s %s %s %pV", dev_driver_string(ibdev->dev.parent), dev_name(ibdev->dev.parent), dev_name(&ibdev->dev), + dynamic_emit_prefix(descriptor, buf), &vaf); } else if (ibdev) { printk(KERN_DEBUG "%s: %pV", dev_name(&ibdev->dev), &vaf); -- 2.17.1
| |