Messages in this thread | | | Date | Thu, 12 Dec 2019 15:02:41 +0100 | From | Greg Kroah-Hartman <> | Subject | Re: [PATCH 4.19 185/243] ARM: dts: sun8i: a23/a33: Fix up RTC device node |
| |
On Thu, Dec 12, 2019 at 02:31:32PM +0100, Pavel Machek wrote: > Hi! > > > The RTC module on the A23 was claimed to be the same as on the A31, when > > in fact it is not. The A31 does not have an RTC external clock output, > > and its internal RC oscillator's average clock rate is not in the same > > range. The A33's RTC is the same as the A23. > > > > This patch fixes the compatible string and clock properties to conform > > to the updated bindings. The register range is also fixed. > > No, this is not okay for v4.19. New compatible is not in > ./drivers/rtc/rtc-sun6i.c, so this will completely break rtc support.
Good catch, I would have thought both of those would happen at the same time.
Now dropped, thanks.
greg k-h
| |