lkml.org 
[lkml]   [2019]   [Dec]   [12]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    /
    Date
    From
    SubjectRe: [PATCH 4.19 185/243] ARM: dts: sun8i: a23/a33: Fix up RTC device node
    Hi!

    > The RTC module on the A23 was claimed to be the same as on the A31, when
    > in fact it is not. The A31 does not have an RTC external clock output,
    > and its internal RC oscillator's average clock rate is not in the same
    > range. The A33's RTC is the same as the A23.
    >
    > This patch fixes the compatible string and clock properties to conform
    > to the updated bindings. The register range is also fixed.

    No, this is not okay for v4.19. New compatible is not in
    ./drivers/rtc/rtc-sun6i.c, so this will completely break rtc support.

    Best regards,
    Pavel

    > +++ b/arch/arm/boot/dts/sun8i-a23-a33.dtsi
    > @@ -565,11 +565,11 @@
    > };
    >
    > rtc: rtc@1f00000 {
    > - compatible = "allwinner,sun6i-a31-rtc";
    > - reg = <0x01f00000 0x54>;
    > + compatible = "allwinner,sun8i-a23-rtc";
    > + reg = <0x01f00000 0x400>;
    > interrupts = <GIC_SPI 40 IRQ_TYPE_LEVEL_HIGH>,
    > <GIC_SPI 41 IRQ_TYPE_LEVEL_HIGH>;
    > - clock-output-names = "osc32k";
    > + clock-output-names = "osc32k", "osc32k-out";
    > clocks = <&ext_osc32k>;
    > #clock-cells = <1>;
    > };

    --
    (english) http://www.livejournal.com/~pavelmachek
    (cesky, pictures) http://atrey.karlin.mff.cuni.cz/~pavel/picture/horses/blog.html
    [unhandled content-type:application/pgp-signature]
    \
     
     \ /
      Last update: 2019-12-12 14:33    [W:4.055 / U:1.152 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site