Messages in this thread | | | Subject | Re: [PATCH] clk: qcom: gcc-sdm845: Add missing flag to votable GDSCs | From | Stephen Boyd <> | Date | Thu, 12 Dec 2019 18:59:18 -0800 |
| |
Quoting Georgi Djakov (2019-11-26 07:34:37) > On sdm845 devices, during boot we see the following warnings (unless we > have added 'pd_ignore_unused' to the kernel command line): > hlos1_vote_mmnoc_mmu_tbu_sf_gdsc status stuck at 'on' > hlos1_vote_mmnoc_mmu_tbu_hf1_gdsc status stuck at 'on' > hlos1_vote_mmnoc_mmu_tbu_hf0_gdsc status stuck at 'on' > hlos1_vote_aggre_noc_mmu_tbu2_gdsc status stuck at 'on' > hlos1_vote_aggre_noc_mmu_tbu1_gdsc status stuck at 'on' > hlos1_vote_aggre_noc_mmu_pcie_tbu_gdsc status stuck at 'on' > hlos1_vote_aggre_noc_mmu_audio_tbu_gdsc status stuck at 'on' > > As the name of these GDSCs suggests, they are "votable" and in downstream > DT, they all have the property "qcom,no-status-check-on-disable", which > means that we should not poll the status bit when we disable them. > > Luckily the VOTABLE flag already exists and it does exactly what we need, > so let's make use of it to make the warnings disappear. > > Fixes: 06391eddb60a ("clk: qcom: Add Global Clock controller (GCC) driver for SDM845") > Reported-by: Rob Clark <robdclark@gmail.com> > Signed-off-by: Georgi Djakov <georgi.djakov@linaro.org>
Taniya, can you ack/review this change?
| |