Messages in this thread | | | Date | Fri, 13 Dec 2019 12:02:05 +1030 | From | "Andrew Jeffery" <> | Subject | Re: [PATCH 04/58] tty/serial: Migrate aspeed_vuart to use has_sysrq |
| |
On Fri, 13 Dec 2019, at 10:36, Dmitry Safonov wrote: > The SUPPORT_SYSRQ ifdeffery is not nice as: > - May create misunderstanding about sizeof(struct uart_port) between > different objects > - Prevents moving functions from serial_core.h > - Reduces readability (well, it's ifdeffery - it's hard to follow) > > In order to remove SUPPORT_SYSRQ, has_sysrq variable has been added. > Initialise it in driver's probe and remove ifdeffery. > > Cc: Andrew Jeffery <andrew@aj.id.au> > Cc: Joel Stanley <joel@jms.id.au> > Cc: linux-arm-kernel@lists.infradead.org > Cc: linux-aspeed@lists.ozlabs.org > Signed-off-by: Dmitry Safonov <dima@arista.com>
Acked-by: Andrew Jeffery <andrew@aj.id.au>
| |