Messages in this thread | | | From | Andy Shevchenko <> | Date | Wed, 11 Dec 2019 17:31:58 +0200 | Subject | Re: [PATCH v3 03/12] platform/x86: asus-wmi: switch to use <linux/units.h> helpers |
| |
On Wed, Dec 11, 2019 at 4:39 PM Akinobu Mita <akinobu.mita@gmail.com> wrote: > > The asus-wmi driver doesn't implement the thermal device functionality > directly, so including <linux/thermal.h> just for DECI_KELVIN_TO_CELSIUS() > is a bit odd. > > This switches the asus-wmi driver to use deci_kelvin_to_millicelsius() in > <linux/units.h>.
> @@ -33,7 +33,7 @@ > #include <linux/seq_file.h> > #include <linux/platform_data/x86/asus-wmi.h> > #include <linux/platform_device.h> > -#include <linux/thermal.h> > +#include <linux/units.h> > #include <linux/acpi.h> > #include <linux/dmi.h>
Similar comment about ordering. Can we move it to the end after dmi.h?
> - return sprintf(buf, "%d\n", value);
> + return sprintf(buf, "%ld\n",
%d -> %ld must be explained in the commit message (e.g. "due to function returned type).
> + deci_kelvin_to_millicelsius(value & 0xFFFF));
I prefer to have this in one line.
-- With Best Regards, Andy Shevchenko
| |