Messages in this thread | | | From | Thomas Renninger <> | Subject | Re: [PATCH 2/3] x86 cpuinfo: implement sysfs nodes for x86 | Date | Wed, 11 Dec 2019 15:12:51 +0100 |
| |
On Wednesday, December 11, 2019 2:56:19 PM CET Greg KH wrote: > On Wed, Dec 11, 2019 at 11:42:35AM +0100, Thomas Renninger wrote: > > If Greg (and others) are ok, I would add "page size exceeding" handling. > > Hm, quick searching for an example I realize that debugfs can exceed page > > size. Is it that hard to expose a sysfs file larger than page size? > > No, there is a simple way to do it, but I'm not going to show you how as > it is NOT how to use sysfs at all :) > > Why are you wanting to dump this whole mess into one file
I wouldn't call a whitespace separated list of CPU feature flags a mess...
> and then parse > it, it's no different from having 100+ different sysfs files and then > doing a readdir(3) on the thing, right?
If this is the way it "has to"/should/"is designed for" to export such (not that complex) data via sysfs...
I do not have such a strong opinion on the how, this is up to maintainers to discuss.
I hope it is agreed that this info is worth exporting via sysfs. So I wait for the "how are CPU feature flags/bugs data" to be exported via sysfs and I volunteer to pick it up and submit a patch out of it.
Thanks,
Thomas
| |