Messages in this thread | | | Date | Wed, 11 Dec 2019 06:59:06 -0500 (EST) | From | Vladis Dronov <> | Subject | Re: [PATCH 4/7] Input: gtco: fix endpoint sanity check |
| |
Thanks, Johan! A fix for a bug indeed.
Best regards, Vladis Dronov | Red Hat, Inc. | The Core Kernel | Senior Software Engineer
----- Original Message ----- > From: "Johan Hovold" <johan@kernel.org> > To: "Dmitry Torokhov" <dmitry.torokhov@gmail.com> > Cc: linux-input@vger.kernel.org, linux-usb@vger.kernel.org, linux-kernel@vger.kernel.org, "Johan Hovold" > <johan@kernel.org>, "stable" <stable@vger.kernel.org>, "Vladis Dronov" <vdronov@redhat.com> > Sent: Tuesday, December 10, 2019 12:37:34 PM > Subject: [PATCH 4/7] Input: gtco: fix endpoint sanity check > > The driver was checking the number of endpoints of the first alternate > setting instead of the current one, something which could lead to the > driver binding to an invalid interface. > > This in turn could cause the driver to misbehave or trigger a WARN() in > usb_submit_urb() that kernels with panic_on_warn set would choke on. > > Fixes: 162f98dea487 ("Input: gtco - fix crash on detecting device without > endpoints") > Cc: stable <stable@vger.kernel.org> # 4.6 > Cc: Vladis Dronov <vdronov@redhat.com> > Signed-off-by: Johan Hovold <johan@kernel.org>
| |