Messages in this thread | | | Subject | Re: [PATCH 02/10] tty: serial: samsung_tty: fix build warning | From | "Enrico Weigelt, metux IT consult" <> | Date | Wed, 11 Dec 2019 12:01:28 +0100 |
| |
On 10.12.19 15:36, Greg Kroah-Hartman wrote:
Hi,
> diff --git a/drivers/tty/serial/samsung_tty.c b/drivers/tty/serial/samsung_tty.c > index 83fd51607741..67c5a84d0a26 100644 > --- a/drivers/tty/serial/samsung_tty.c > +++ b/drivers/tty/serial/samsung_tty.c > @@ -1851,7 +1851,10 @@ static int s3c24xx_serial_init_port(struct s3c24xx_uart_port *ourport, > > /* Device driver serial port probe */ > > +#ifdef CONFIG_OF > static const struct of_device_id s3c24xx_uart_dt_match[]; > +#endif > +
By the way: I've got some patch for conditionally declaring of match tables (including MODULE_DEVICE_TABE() call), so such ifdef's aren't needed anymore.
Would you like to see it ? (IIRC already posted it quite some time ago, but probably went unnoticed)
--mtx
--- Enrico Weigelt, metux IT consult Free software and Linux embedded engineering info@metux.net -- +49-151-27565287
| |