Messages in this thread | | | From | Ard Biesheuvel <> | Date | Wed, 11 Dec 2019 09:38:54 +0000 | Subject | Re: [PATCH 1/2] crypto: arm/curve25519 - add arch-specific key generation function |
| |
On Wed, 11 Dec 2019 at 10:27, Jason A. Donenfeld <Jason@zx2c4.com> wrote: > > Somehow this was forgotten when Zinc was being split into oddly shaped > pieces, resulting in linker errors.
Zinc has no historical significance here, so it doesn't make sense to keep referring to it in the commit logs.
> The x86_64 glue has a specific key > generation implementation, but the Arm one does not. However, it can > still receive the NEON speedups by calling the ordinary DH function > using the base point. > > Signed-off-by: Jason A. Donenfeld <Jason@zx2c4.com>
With the first sentence dropped,
Acked-by: Ard Biesheuvel <ardb@kernel.org>
> --- > arch/arm/crypto/curve25519-glue.c | 7 +++++++ > 1 file changed, 7 insertions(+) > > diff --git a/arch/arm/crypto/curve25519-glue.c b/arch/arm/crypto/curve25519-glue.c > index f3f42cf3b893..776ae07e0469 100644 > --- a/arch/arm/crypto/curve25519-glue.c > +++ b/arch/arm/crypto/curve25519-glue.c > @@ -38,6 +38,13 @@ void curve25519_arch(u8 out[CURVE25519_KEY_SIZE], > } > EXPORT_SYMBOL(curve25519_arch); > > +void curve25519_base_arch(u8 pub[CURVE25519_KEY_SIZE], > + const u8 secret[CURVE25519_KEY_SIZE]) > +{ > + return curve25519_arch(pub, secret, curve25519_base_point); > +} > +EXPORT_SYMBOL(curve25519_base_arch); > + > static int curve25519_set_secret(struct crypto_kpp *tfm, const void *buf, > unsigned int len) > { > -- > 2.24.0 >
| |