Messages in this thread | | | Subject | Re: [PATCH 0/6] Fix various comment errors | From | Xiaoyao Li <> | Date | Thu, 12 Dec 2019 10:59:00 +0800 |
| |
Hi,
On 12/12/2019 10:08 AM, linmiaohe wrote: > Sean Christopherson wrote: >> On Wed, Dec 11, 2019 at 02:26:19PM +0800, linmiaohe wrote: >>> From: Miaohe Lin <linmiaohe@huawei.com> >>> >>> Miaohe Lin (6): >>> KVM: Fix some wrong function names in comment >>> KVM: Fix some out-dated function names in comment >>> KVM: Fix some comment typos and missing parentheses >>> KVM: Fix some grammar mistakes >>> KVM: hyperv: Fix some typos in vcpu unimpl info >>> KVM: Fix some writing mistakes >> >> Regarding the patch organizing, I'd probably group the comment changes based on what files they touch as opposed to what type of comment issue they're fixing. >> >> E.g. three patches for the comments >> >> KVM: VMX: Fix comment blah blah blah >> KVM: x86: Fix comment blah blah blah >> KVM: Fix comment blah blah blah >> >> and one patch for the print typo in hyperv >> >> KVM: hyperv: Fix some typos in vcpu unimpl info >> >> For KVM, the splits don't matter _that_ much since they more or less all get routed through the maintainers/reviewers, but it is nice when patches can be contained to specific subsystems/areas as it allows people to easily skip over patches that aren't relevant to them. >> > > Many thanks for your advice and patient explanation. I feel sorry for my poor patch organizing. > I would reorganize my patches. Thanks again. >
Could you please use the "In-Reply-To" tag when you reply a mail next time? Otherwise every replying mail from you is listed as a separate one, but not folded into the initial thread in my mail client.
| |